Skip to content

fix: allow CSS-wide keywords in font-family-fallbacks#391

Merged
DMartens merged 4 commits intoeslint:mainfrom
sethamus:font-family-fallbacks-css-wide-keywords
Apr 9, 2026
Merged

fix: allow CSS-wide keywords in font-family-fallbacks#391
DMartens merged 4 commits intoeslint:mainfrom
sethamus:font-family-fallbacks-css-wide-keywords

Conversation

@sethamus
Copy link
Copy Markdown
Contributor

@sethamus sethamus commented Mar 4, 2026

Prerequisites checklist

AI acknowledgment

  • I did not use AI to generate this PR.
  • (If the above is not checked) I have reviewed the AI-generated content before submitting.

What is the purpose of this pull request?

This PR fixes false positives in css/font-family-fallbacks by allowing CSS-wide keywords (e.g. inherit, initial, unset, revert, revert-layer) for font-family/font, since they shouldn’t be required to include fallback/generic fonts.

What changes did you make? (Give an overview)

  • Updated the rule to treat CSS-wide keywords as always valid (including when they come from var() values).
  • Added tests covering font-family and shorthand font CSS-wide keyword cases.
  • Updated the rule docs to mention CSS-wide keywords are allowed.

Related Issues

Fixes #387

Is there anything you'd like reviewers to focus on?

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Mar 4, 2026
@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Mar 4, 2026
@eslint-github-bot eslint-github-bot bot mentioned this pull request Mar 4, 2026
Closed
3 tasks
Tanujkanti4441
Tanujkanti4441 reviewed Mar 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Tanujkanti4441 Tanujkanti4441 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, looks good, just a suggestion regarding docs.

@Tanujkanti4441 Tanujkanti4441 moved this from Needs Triage to Implementing in Triage Mar 4, 2026
@Tanujkanti4441 Tanujkanti4441 added the accepted There is consensus among the team that this change meets the criteria for inclusion label Mar 4, 2026
DMartens
DMartens reviewed Mar 5, 2026
View reviewed changes
@sethamus sethamus marked this pull request as draft March 16, 2026 08:06
@sethamus sethamus marked this pull request as ready for review April 9, 2026 00:41
DMartens
DMartens approved these changes Apr 9, 2026
View reviewed changes
Copy link
Copy Markdown

@DMartens DMartens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thanks.

@DMartens DMartens merged commit 638c6ee into eslint:main Apr 9, 2026
33 checks passed
@github-project-automation github-project-automation bot moved this from Implementing to Complete in Triage Apr 9, 2026
@eslintbot eslintbot mentioned this pull request Apr 8, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nzakas nzakas nzakas left review comments

@Tanujkanti4441 Tanujkanti4441 Tanujkanti4441 left review comments

@Pixel998 Pixel998 Pixel998 left review comments

@DMartens DMartens DMartens approved these changes

Assignees

No one assigned

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion bug Something isn't working

Projects

Triage
Status: Complete

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: font-family-fallbacks reports an error for font-family: inherit

5 participants

@sethamus @nzakas @DMartens @Tanujkanti4441 @Pixel998